Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: split rubocop from bulk dependabot #7463

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

colinbruce
Copy link
Contributor

What

The first version did not work as the documentation suggested, so this is V2
The rubocop changes block so many other gems, we agreed to try splitting liek this and see if it allows us to work on rubocop fixes without delaying other gems

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

The rubocop changes block so many other gems, we agreed to
try splitting liek this and see if it allows us to work on
rubocop fixes without delaying other gems
@colinbruce colinbruce marked this pull request as ready for review November 21, 2024 15:35
@colinbruce colinbruce requested a review from a team as a code owner November 21, 2024 15:35
@colinbruce colinbruce added the ready for review Please review label Nov 21, 2024
@colinbruce colinbruce merged commit 1566863 into main Nov 21, 2024
15 checks passed
@colinbruce colinbruce deleted the chore/split-dependabot branch November 21, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants