Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5288: SCA CCMS payload testing #7339

Closed
wants to merge 9 commits into from
Closed

AP-5288: SCA CCMS payload testing #7339

wants to merge 9 commits into from

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Oct 21, 2024 •
edited
Loading

What

Link to story

Note

WORK IN PROGRESS

This replaces #7222
It will make state machine changes and then pull in the original changes and
become the one-PR-to-rule-them-all moving forward for SCA CCMS changes

Warning

This will be used for testing the submissions to CCMS DEV - #7432 has been created for code review
This PR will be rebased on that and include the necessary routing for testing, while retaining a static URL for CCMS/CapGem devs to create test cases

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the ap-5288/sca-ccms-payload-updates branch 9 times, most recently from fe3b704 to f538d8a Compare October 22, 2024 10:42
@colinbruce colinbruce mentioned this pull request Oct 22, 2024
Closed
@colinbruce colinbruce force-pushed the ap-5288/sca-ccms-payload-updates branch 5 times, most recently from ecf6564 to 2ef8fcb Compare October 24, 2024 13:44
@colinbruce colinbruce force-pushed the ap-5288/sca-ccms-payload-updates branch 5 times, most recently from b6d5166 to db1b351 Compare November 7, 2024 12:14
@colinbruce colinbruce force-pushed the ap-5288/sca-ccms-payload-updates branch 3 times, most recently from ae2ded7 to 5f6a262 Compare November 13, 2024 13:11
@colinbruce colinbruce changed the title AP-5288: SCA CCMS payload updates AP-5288: SCA CCMS payload testing Nov 14, 2024
@colinbruce colinbruce force-pushed the ap-5288/sca-ccms-payload-updates branch 4 times, most recently from c590d69 to 01ad473 Compare November 15, 2024 09:21
@colinbruce colinbruce changed the base branch from main to ap-5288/code-only-sca-ccms-payload-updates November 18, 2024 14:51
@colinbruce colinbruce force-pushed the ap-5288/sca-ccms-payload-updates branch from 01ad473 to 88038a3 Compare November 18, 2024 14:51
@colinbruce colinbruce force-pushed the ap-5288/sca-ccms-payload-updates branch 2 times, most recently from 783722c to 6608a8d Compare November 19, 2024 07:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@colinbruce
AP-5288: Remove SCA handling from non-means-tested state machine
6afc175
@colinbruce
AP-5288: Create SCA state machine
ec518ff 
Extract methods and tests from non-means-tested state machine

Implement new factory and traits as needed
@colinbruce
AP-5288: Update CheckProviderAnswersStep to handle new state machine
10253d3
@colinbruce
AP-5288: Add SpecialChildrenAct Case Add Requestor
e786ab8 
This will allow us to build a specific payload for SCA applications
without branching an existing state machine
@colinbruce
AP-5288: Update the application_digest and legal_aid_application models
3cfaec1 
These was some duplicated methods and similar patterns
used in both.  This simplifies the interface and reduces
duplication
@colinbruce
AP-5288: Update AmendmentType handling
3a67983 
We were sending amendment types based off DF logic, not non-SCA DF logic
Use the new `non_sca_used_delegated_functions?` handler, and call it where
appropriate to remove it from the payload.  Also remove `DevolvedPowersDate`
as we know this is not needed on an SCA application payload
@colinbruce
AP-5288: Create new SCA attribute block list and handlers
a46285b
@colinbruce
AP-5288: Update MEANS_TASK_AUTO_GEN handling
e793193 
Ensure it is set to true when auto-granting and not
generated for other submissions
@colinbruce colinbruce force-pushed the ap-5288/code-only-sca-ccms-payload-updates branch from 103f74e to e793193 Compare November 26, 2024 08:52
@colinbruce
AP-5288: this branch allows testing on a known URL
fa8aef4 
But will be an empty commit for now
@colinbruce colinbruce force-pushed the ap-5288/sca-ccms-payload-updates branch from 6608a8d to fa8aef4 Compare November 26, 2024 08:52
@colinbruce colinbruce force-pushed the ap-5288/code-only-sca-ccms-payload-updates branch from e793193 to 90cc18f Compare November 26, 2024 13:38
Base automatically changed from ap-5288/code-only-sca-ccms-payload-updates to main November 27, 2024 06:58
@colinbruce colinbruce closed this Nov 29, 2024
@colinbruce colinbruce deleted the ap-5288/sca-ccms-payload-updates branch November 29, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colinbruce