Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: pdf smoke test #7000

Closed
wants to merge 6 commits into from
Closed

Chore: pdf smoke test #7000

wants to merge 6 commits into from

Conversation

colinbruce
Copy link
Contributor

What

We have seen issues with tests build on circle ci passing but pdf generation on the alpine build failing

This PR attempts to add a rake task to test imapct of smoke testing a Grover test before pushing to ECR

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the chore/pdf-smoke-test branch 8 times, most recently from 8ce472c to 9831652 Compare August 5, 2024 07:08
We have seen issues with tests build on circle ci
passing but pdf generation on the alpine build
failing

This PR attempts to add a rake task to test
imapct of smoke testing a Grover test before
pushing to ECR
@colinbruce colinbruce force-pushed the chore/pdf-smoke-test branch from 9831652 to de3a3e4 Compare August 5, 2024 07:19
revert the pdf fix, deployment should fail
This should trigger a deploy fail and sentry alert
Copy link

sonarqubecloud bot commented Aug 7, 2024

@colinbruce
Copy link
Contributor Author

I never got this working to my satisfaction... my branch is still local and we can revisit if we have more puppeteer and grover issues in the future

@colinbruce colinbruce closed this Dec 3, 2024
@colinbruce colinbruce deleted the chore/pdf-smoke-test branch December 3, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant