Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ap 5097 convert apostrophes ccms payload #6881

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Ap 5097 convert apostrophes ccms payload #6881

wants to merge 14 commits into from

Conversation

kmahern
Copy link
Contributor

@kmahern kmahern commented Jun 27, 2024 •
edited
Loading

What

Link to story

Substitute curly apostrophes for straight apostrophes anywhere in CCMS payload.
When attempting to match applicants with CCMS applicants substitute curly apostrophes for straight apostrophes in last_name and last_name_at_birth.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@kmahern kmahern force-pushed the ap-5097-convert-apostrophes-ccms-payload branch 3 times, most recently from e5d9bca to 94a4779 Compare July 2, 2024 07:20
@kmahern kmahern marked this pull request as ready for review July 2, 2024 07:34
@kmahern kmahern requested a review from a team as a code owner July 2, 2024 07:34
@kmahern kmahern added the ready for review Please review label Jul 2, 2024
@kmahern kmahern added UAT and removed ready for review Please review labels Jul 4, 2024
@naseberry naseberry force-pushed the ap-5097-convert-apostrophes-ccms-payload branch 2 times, most recently from f9a6c4d to 5942a02 Compare July 29, 2024 09:19
naseberry and others added 13 commits August 5, 2024 09:29
@naseberry @colinbruce
ccms requestor char replacement method
9bc429f 
ideation: replacement disallowed chars,
allows Apply to extend if other edge cases are identified,
may affect the payload
@naseberry @colinbruce
Update case_add_requestor payload
b3bc635 
Intercept the case_add_requestor payload,
then replace the ccms disallowed chars
@naseberry @colinbruce
Add spec
e6cbb3d 
this is a WIP
@kmahern @colinbruce
ap-5097: fix spec
66bb2e1
@kmahern @colinbruce
ap-5097: add opening curly apostrophe to gsub
100c1d8
@kmahern @colinbruce
ap-5097: rename ccms_character_replacement and call in formatted_xml
65e00ae
@kmahern @colinbruce
ap-5097: test special characters in applicant_add_requestor
4eea0b7
@kmahern @colinbruce
ap-5097: test special characters in applicant_search_requestor
3643adf
@kmahern @colinbruce
ap-5097: allow applicant names containing special characters to be ma…
566d5bd 
…tched with ccms records
@kmahern @colinbruce
ap-5097: create shared CHARACTERS hash in CCMS::Requestors::BaseReque…
418245e 
…stor

that can also be used for applicant matching
@kmahern @colinbruce
ap-5097: Attempt to clarify specs by specifying opening or closing cu…
aaf0560 
…rly quotes

Attempt to clarify spec descriptions by specifying whether it is testing
replacement of opening or closing curly quotes
@kmahern @colinbruce
ap-5097: Rename CHARACTERS hash as SPECIAL_CHARACTER_REPLACEMENTS
e1644a1 
Rename hash to make variable name more descriptive
@colinbruce
AP-5097: Update replacement to use unicode apostrophe
aeecb60
@colinbruce colinbruce force-pushed the ap-5097-convert-apostrophes-ccms-payload branch from 4410255 to aeecb60 Compare August 5, 2024 08:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinbruce colinbruce colinbruce left review comments

@naseberry naseberry naseberry approved these changes

Assignees
No one assigned
Labels
UAT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmahern @colinbruce @naseberry