Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: check page title in feature test #6173

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

agoldstone93
Copy link
Contributor

What

Check page title in feature test
Remove todo from codebase

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 marked this pull request as ready for review January 3, 2024 16:42
@agoldstone93 agoldstone93 requested a review from a team as a code owner January 3, 2024 16:42
@agoldstone93 agoldstone93 added the ready for review Please review label Jan 3, 2024
@colinbruce colinbruce added approved Approved by code reviewers and removed ready for review Please review labels Jan 4, 2024
@agoldstone93 agoldstone93 force-pushed the chore-todo-check-page-title-in-feature-test branch from f8199eb to 844cdd3 Compare January 4, 2024 09:25
Remove todo from codebase
@agoldstone93 agoldstone93 force-pushed the chore-todo-check-page-title-in-feature-test branch from 844cdd3 to dcb3b6c Compare January 4, 2024 09:53
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@agoldstone93 agoldstone93 merged commit 2ff1b8c into main Jan 4, 2024
14 checks passed
@agoldstone93 agoldstone93 deleted the chore-todo-check-page-title-in-feature-test branch January 4, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants