Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4604: Validation so "none" and another checkbox cannot both be selected #6107

Conversation

agoldstone93
Copy link
Contributor

What

Link to story

Add extra validation so "None of the above" and another checkbox cannot both be selected when JS is disabled

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the ap-4604-bug-can-select-none-and-another-checkbox-with-js-disabled branch 2 times, most recently from 30dd18a to 33fb29e Compare December 12, 2023 11:22
@agoldstone93 agoldstone93 changed the title AP-4606: Validation so "none" and another checkbox cannot both be selected AP-4604: Validation so "none" and another checkbox cannot both be selected Dec 13, 2023
@agoldstone93 agoldstone93 force-pushed the ap-4604-bug-can-select-none-and-another-checkbox-with-js-disabled branch 8 times, most recently from 8c0f3ee to 3fe5c16 Compare December 19, 2023 11:13
@agoldstone93 agoldstone93 marked this pull request as ready for review December 19, 2023 11:45
@agoldstone93 agoldstone93 requested a review from a team as a code owner December 19, 2023 11:45
@agoldstone93 agoldstone93 added the ready for review Please review label Dec 19, 2023
@agoldstone93 agoldstone93 force-pushed the ap-4604-bug-can-select-none-and-another-checkbox-with-js-disabled branch from bffda3d to 7b0b5cb Compare December 20, 2023 14:00
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@agoldstone93 agoldstone93 merged commit 7a97117 into main Dec 20, 2023
15 checks passed
@agoldstone93 agoldstone93 deleted the ap-4604-bug-can-select-none-and-another-checkbox-with-js-disabled branch December 20, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants