Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/helm delete failures #5952

Closed
wants to merge 5 commits into from
Closed

Test/helm delete failures #5952

wants to merge 5 commits into from

Conversation

colinbruce
Copy link
Contributor

What

Link to story

Describe what you did and why.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Replace inputs with secret names and add --debug to the final command

Not sure this will run as expected but 🤞
speed up testing remove flaky tests that slow down process!
@colinbruce colinbruce closed this Nov 3, 2023
@colinbruce colinbruce reopened this Nov 3, 2023
@colinbruce colinbruce force-pushed the test/helm-delete-failures branch from 20503c9 to f280984 Compare November 3, 2023 15:19
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@colinbruce colinbruce closed this Nov 3, 2023
@colinbruce colinbruce deleted the test/helm-delete-failures branch November 3, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant