Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-3887: Add Partner CCMS values #5949

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

colinbruce
Copy link
Contributor

What

Link to story

This implements the CCMS values suggested by the PUI xml output when a partner is added

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

This implements the CCMS values suggested by the PUI
xml output when a partner is added
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@colinbruce colinbruce added the ready for review Please review label Nov 6, 2023
@colinbruce colinbruce marked this pull request as ready for review November 6, 2023 09:46
@colinbruce colinbruce requested a review from a team as a code owner November 6, 2023 09:46
Copy link
Contributor

@RoseSAK RoseSAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@RoseSAK RoseSAK added approved Approved by code reviewers and removed ready for review Please review labels Nov 8, 2023
@colinbruce colinbruce added the UAT label Nov 8, 2023
@colinbruce colinbruce merged commit 560cc33 into main Nov 8, 2023
7 checks passed
@colinbruce colinbruce deleted the ap-3887/ccms-partner-submission branch November 8, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers UAT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants