Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump govuk-frontend from 4.6.0 to 4.7.0 #5941

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

naseberry
Copy link
Contributor

What

Manually bump govuk-frontend from 4.6.0 to 4.7.0

It's been over 3 months since v4.7.0 was released, manually bumping it as our bot has not done it.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@naseberry naseberry marked this pull request as ready for review November 2, 2023 17:08
@naseberry naseberry requested a review from a team as a code owner November 2, 2023 17:09
yarn.lock Show resolved Hide resolved
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@colinbruce colinbruce added the approved Approved by code reviewers label Nov 3, 2023
@naseberry naseberry force-pushed the build-govuk-frontend-4.7.0 branch from 580f482 to 17f0ac1 Compare November 3, 2023 09:42
@colinbruce colinbruce closed this Nov 3, 2023
@colinbruce colinbruce reopened this Nov 3, 2023
@colinbruce
Copy link
Contributor

Sorry @naseberry I'm testing a helm delete fix and had the wrong tab open! 😬

@naseberry naseberry force-pushed the build-govuk-frontend-4.7.0 branch from 17f0ac1 to 4a95131 Compare November 6, 2023 08:31
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@naseberry naseberry merged commit a251407 into main Nov 6, 2023
7 checks passed
@naseberry naseberry deleted the build-govuk-frontend-4.7.0 branch November 6, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants