AP-4575: Add copy case page flows #5932

jsugarman · 2023-11-01T14:16:33Z

What

Add copy case feature

The ability to copy case details from one application to another
is considered a prerequisite for the linking cases feature.

This branch adds the pages flows but does not do a full clone/copy of the necessary case details - see AP-4577 for that. Neither does it add the CYA page changes - see AP-4601 for that

Checklist

Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

To store answer to question "Copy an application to your application?" inline with designs.

Add controller form and view to ask the user if they want to copy an existing application to this one.

Use deep_clonable. This is one option, amoeba being another.

Required and used as an example of using deep clone to copy nested associations.

…sign

Cover the conditional flow for copy case

Inline with conventions used for other controllers

Spec the additional validation whereby search only checks for provider specific case references.

Confirmed with design as users may want to go and lookup a reference on the application index page and this would allow them to go back and forth to the correct step.

Inline with designs

colinbruce · 2023-11-07T12:30:51Z

An observation from outside the team...
Could the copy_case controllers, views, etc be namespaced into a folder to prevent the provider namespace bloating?
e.g. app/controllers/providers/copy_case/searches, etc ?
It helped with Partner work that we could find a section easier as it was in it's own namespaced folder :)

spec/requests/providers/copy_case_invitations_controller_spec.rb

spec/support/shared_context/session_double_shared_context.rb

colinbruce

Looks good, a couple of observations from a linked-cases non-expert!

So that we can store the id of the application for copying from for use in both the search and confirmation pages withtout regard to session expiry edge cases, plus use the legal aid application reference in the check your answers page in line with design.

…se_id

…y_case_id

jsugarman · 2023-11-08T07:59:52Z

An observation from outside the team... Could the copy_case controllers, views, etc be namespaced into a folder to prevent the provider namespace bloating? e.g. app/controllers/providers/copy_case/searches, etc ? It helped with Partner work that we could find a section easier as it was in it's own namespaced folder :)

Yeah, I tried namespacing the controllers and views first and hit problems, will have another look.

Inline with current designs

jsugarman · 2023-11-09T13:44:12Z

An observation from outside the team... Could the copy_case controllers, views, etc be namespaced into a folder to prevent the provider namespace bloating? e.g. app/controllers/providers/copy_case/searches, etc ? It helped with Partner work that we could find a section easier as it was in it's own namespaced folder :)

This is done now. see commit

kmahern

lgtm 👍

agoldstone93

Just one comment

app/controllers/providers/copy_case/searches_controller.rb

sonarqubecloud · 2023-11-09T16:43:59Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

jsugarman force-pushed the ap-4575/copy-case-page-flows branch from 9877d46 to 0dee58a Compare November 1, 2023 14:19

jsugarman mentioned this pull request Nov 1, 2023

AP-4380: Add copy case feature #5895

Closed

7 tasks

jsugarman force-pushed the ap-4575/copy-case-page-flows branch 8 times, most recently from a6a5de5 to 26b334b Compare November 6, 2023 14:01

jsugarman added 20 commits November 6, 2023 15:20

AP-4575: Add copy_case column to legal_aid_application

319a111

To store answer to question "Copy an application to your application?" inline with designs.

AP-4575: Add copy case invitation form

09299ab

Add controller form and view to ask the user if they want to copy an existing application to this one.

AP-4575: Add copy case find and confirmation components

960dd9d

AP-4575: Add cloner service and copy proceedings

a0c65f8

Use deep_clonable. This is one option, amoeba being another.

AP-4575: Include proceeding scope limitations

9eed525

Required and used as an example of using deep clone to copy nested associations.

AP-4575: Add basic copy case feature tests and adjust content from de…

e6ea71d

…sign

AP-4575: Add copy_case_invitations request specs

4f4b158

AP-4575: Extend addresses controller spec

428cfa1

Cover the conditional flow for copy case

AP-4575: rename addresses controller spec

49c0f54

Inline with conventions used for other controllers

AP-4575: Extend address selections controller spec

b77d2b2

AP-4575: Add copy_case_searches request specs

fbfea58

AP-4575: Add copy_case_confirmations request specs

5e10d03

AP-4575: Add copy_case/invitation_form specs

bd330dc

AP-4575: Add copy_case/search_form specs

9e2d3e8

AP-4575: add save! alias to ensure correct calls made

4eec414

AP-4575: correct copy_case_confirmations form_params

b8cc256

AP-4575: correct copy_case_searches form_params

cc16363

AP-4575: amend copy_case_searches_controller_spec

a126328

Spec the additional validation whereby search only checks for provider specific case references.

AP-4575: enable save as draft for search

000e666

Confirmed with design as users may want to go and lookup a reference on the application index page and this would allow them to go back and forth to the correct step.

AP-4575: Add confirmation_form spec

c359b60

jsugarman added 3 commits November 7, 2023 09:30

AP-4575: Refactor copy_case/confirmation_form

5eae1cc

AP-4575: Extend copy_case/search_form spec

bc0c108

AP-4575: Amend copy case confirmation table to summary list

d5520ec

Inline with designs

jsugarman marked this pull request as ready for review November 7, 2023 11:49

jsugarman requested a review from a team as a code owner November 7, 2023 11:49

jsugarman added the ready for review Please review label Nov 7, 2023

colinbruce reviewed Nov 7, 2023

View reviewed changes

spec/requests/providers/copy_case_invitations_controller_spec.rb Outdated Show resolved Hide resolved

colinbruce reviewed Nov 7, 2023

View reviewed changes

spec/support/shared_context/session_double_shared_context.rb Outdated Show resolved Hide resolved

colinbruce reviewed Nov 7, 2023

View reviewed changes

jsugarman added 4 commits November 7, 2023 13:52

AP-4575: Update copy_case searches controller and form to use copy_ca…

10f6598

…se_id

AP-4575: Amend copy case confirmations controller and form to use cop…

3cfd966

…y_case_id

AP-4575: remove unneeded have_error_message spec helper method

e57970a

AP-4575: Namespace copy_case controllers

eb29620

jsugarman force-pushed the ap-4575/copy-case-page-flows branch from 91f7e49 to eb29620 Compare November 8, 2023 09:32

AP-4575: Update content for copy case invitations page

0aebd49

Inline with current designs

kmahern approved these changes Nov 9, 2023

View reviewed changes

agoldstone93 reviewed Nov 9, 2023

View reviewed changes

app/controllers/providers/copy_case/searches_controller.rb Outdated Show resolved Hide resolved

AP-4575: Remove unneeded save_continue_or_draft override

4860c31

jsugarman requested review from agoldstone93 and colinbruce November 9, 2023 16:45

jsugarman added UAT approved Approved by code reviewers and removed ready for review Please review labels Nov 10, 2023

jsugarman merged commit 7691800 into main Nov 13, 2023
7 checks passed

jsugarman deleted the ap-4575/copy-case-page-flows branch November 13, 2023 08:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AP-4575: Add copy case page flows #5932

AP-4575: Add copy case page flows #5932

jsugarman commented Nov 1, 2023 •

edited by jira bot

Loading

colinbruce commented Nov 7, 2023

colinbruce left a comment

jsugarman commented Nov 8, 2023

jsugarman commented Nov 9, 2023

kmahern left a comment

agoldstone93 left a comment

sonarqubecloud bot commented Nov 9, 2023

AP-4575: Add copy case page flows #5932

AP-4575: Add copy case page flows #5932

Conversation

jsugarman commented Nov 1, 2023 • edited by jira bot Loading

What

Checklist

colinbruce commented Nov 7, 2023

colinbruce left a comment

Choose a reason for hiding this comment

jsugarman commented Nov 8, 2023

jsugarman commented Nov 9, 2023

kmahern left a comment

Choose a reason for hiding this comment

agoldstone93 left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 9, 2023

jsugarman commented Nov 1, 2023 •

edited by jira bot

Loading