Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rails 7 gem and node #5921

Merged
merged 9 commits into from
Nov 2, 2023
Merged

Update Rails 7 gem and node #5921

merged 9 commits into from
Nov 2, 2023

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Oct 30, 2023

What

This PR updates the required Rails changes:

  • gem and node options to Rails 7.1.1
  • removing legacy handler block
  • setting load defaults, etc;

as well as:

  • A couple of the require blocks seem to no longer autoload from the precise location so these were updated to load explicitly
  • Serialize calls now require am explicit coder: type and this has been set to YAML
  • The action_dispatch.show_exceptions setting was updated as the original setting made the cucumber tests very noisy
  • A change in rails 7.1 now raises errors when any i18n lookup fails. Previously this only failed on views so this adds some error handling in the application code and changes some failing tests, where previously, a deleted key was expected not to be on the page was passing because it didn't find a translation missing error on the view!

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce marked this pull request as ready for review October 31, 2023 07:38
@colinbruce colinbruce requested a review from a team as a code owner October 31, 2023 07:38
@colinbruce colinbruce added the ready for review Please review label Oct 31, 2023
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Codewise looks fine. much prefer the use of plain text in place of translations in specs.

I imagine some mobbing and/or extensive manual testing would be necessary to feel more confident. On Assure there was an issue with devise that passed all tests but prevented login on staging/production due to AR encryption.

@colinbruce colinbruce added UAT approved Approved by code reviewers and removed ready for review Please review labels Oct 31, 2023
These are no longer autoloaded
Set to YAML by default as this was the previous standard type
This was causing noise in the test runs due
to being replaced with :none and false being
incorrect rather than ignored
A test was complaining of missing value - comments
indicate that this should probably be removed rather
than extended but that is a problem for FutureColin
A change in rails 7.1 now raises errors when _any_ i18n lookup
fails.  Previously this only failed on views.
A change in rails 7.1 now raises errors when _any_ i18n lookup
fails.  Previously these tests failed because a missing translation
often meant that a negative test would pass, I expect this text
to be missing, paired with a missing translation was a definite fail!

Now that the error is raised, I have replaced the missong, often
moved, translations with the text it _should_ have been confirming
as missing
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@colinbruce colinbruce merged commit 693373c into main Nov 2, 2023
7 checks passed
@colinbruce colinbruce deleted the test/rails-7 branch November 2, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers UAT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants