-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rails 7 gem and node #5921
Conversation
c9c1a2b
to
cab6066
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Codewise looks fine. much prefer the use of plain text in place of translations in specs.
I imagine some mobbing and/or extensive manual testing would be necessary to feel more confident. On Assure there was an issue with devise that passed all tests but prevented login on staging/production due to AR encryption.
These are no longer autoloaded
Set to YAML by default as this was the previous standard type
This was causing noise in the test runs due to being replaced with :none and false being incorrect rather than ignored
A test was complaining of missing value - comments indicate that this should probably be removed rather than extended but that is a problem for FutureColin
A change in rails 7.1 now raises errors when _any_ i18n lookup fails. Previously this only failed on views.
A change in rails 7.1 now raises errors when _any_ i18n lookup fails. Previously these tests failed because a missing translation often meant that a negative test would pass, I expect this text to be missing, paired with a missing translation was a definite fail! Now that the error is raised, I have replaced the missong, often moved, translations with the text it _should_ have been confirming as missing
cab6066
to
3485c03
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What
This PR updates the required Rails changes:
as well as:
require
blocks seem to no longer autoload from the precise location so these were updated to load explicitlySerialize
calls now require am explicitcoder:
type and this has been set to YAMLChecklist
Before you ask people to review this PR:
bundle exec rake
git rebase main
.