Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-4427: Add alert and area-live=assertive for screen readers and reformat sign in page #5894

Merged
merged 1 commit into from
Oct 25, 2023
Merged

AP-4427: Add alert and area-live=assertive for screen readers and reformat sign in page #5894

merged 1 commit into from
Oct 25, 2023

Conversation

skdejong
Copy link
Contributor

@skdejong skdejong commented Oct 20, 2023 •
edited
Loading

What

Announce error message via screen reader

Added role="alert" aria-live="assertive" to sign in page so that error message will be announced via screen readers.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@skdejong skdejong added ready for review Please review ruby Pull requests that update Ruby code labels Oct 20, 2023
@skdejong skdejong self-assigned this Oct 20, 2023
jsugarman
jsugarman approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@jsugarman jsugarman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, tried it out and it seems to work fine.

I see you have based this off the gems new template. I wonder if it could be further govuk'erised but it is a lot better than it was generally anyway!

@jsugarman jsugarman marked this pull request as ready for review October 23, 2023 09:43
@jsugarman jsugarman requested a review from a team as a code owner October 23, 2023 09:43
@jsugarman jsugarman added the approved Approved by code reviewers label Oct 23, 2023
@skdejong skdejong force-pushed the ap-4427-announce-error-message-via-screen-reader branch from 6cd36f3 to 07adbc7 Compare October 24, 2023 16:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@skdejong skdejong added UAT and removed ready for review Please review labels Oct 24, 2023
@skdejong skdejong merged commit e28fc9e into main Oct 25, 2023
7 checks passed
@skdejong skdejong deleted the ap-4427-announce-error-message-via-screen-reader branch October 25, 2023 08:13
@skdejong skdejong added Ready to merge Has passed UAT testing and can be merged into master and removed UAT labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsugarman jsugarman jsugarman approved these changes

Assignees

@skdejong skdejong

Labels
approved Approved by code reviewers Ready to merge Has passed UAT testing and can be merged into master ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skdejong @jsugarman