Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4489: add different error messages for whether client has partner #5893

Closed

Conversation

agoldstone93
Copy link
Contributor

What

Link to story

Add proof of concept for specific messages depending on whether client has a partner

Client only:
image

Client and partner:
image

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Add proof of concept for specific messages depending
on whether client has a partner
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@agoldstone93 agoldstone93 added the ready for review Please review label Oct 23, 2023
@agoldstone93 agoldstone93 marked this pull request as ready for review October 23, 2023 07:51
@agoldstone93 agoldstone93 requested a review from a team as a code owner October 23, 2023 07:51
Copy link
Contributor

@RoseSAK RoseSAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me although I'm thinking it will be quite a lot of work to manually implement the separate client/partner error messages, just because I think there will be quite a few affected pages? But I'm not sure that there's a better/easier solution so happy to go with this if everyone else is 👍

@RoseSAK RoseSAK added approved Approved by code reviewers and removed ready for review Please review labels Oct 23, 2023
@agoldstone93 agoldstone93 deleted the ap-4489-investigate-specific-partner-error-messages branch November 7, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants