AP-4505: Test branch #5874
Closed
AP-4505: Test branch #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsugarman
force-pushed
the
ap-4505/test-branch
branch
4 times, most recently
from
6a7e851 to
a983d15
Compare
Change the apps sidekiq client to use unamespaced redis for "new" jobs but add a "drainer" worker to process already enqueued "namespaced" jobs.
This can be used to test whether the drainer is working
```ruby
\# Test "new" denamespaced sidekiq is being drained/processed
client = Sidekiq::Client.new
client.push('queue' => 'default', 'class' => TestMailJob , 'args' => ['[email protected]', 'Testing new denamespaced job processing'])
```
```ruby
\# Test "old" namespaced sidekiq is being drained/processed
redis_url = "rediss://:#{ENV.fetch('REDIS_PASSWORD', nil)}@#{ENV.fetch('REDIS_HOST', nil)}:6379"
redis_namespace = ENV.fetch("HOST", "laa-apply")
redis_connection = Sidekiq::RedisConnection.create(url: redis_url, namespace: redis_namespace)
client = Sidekiq::Client.new(redis_connection)
client.push('queue' => 'default', 'class' => TestMailJob , 'args' => ['[email protected]', 'Testing old namespaced job processing'])
```
- Add redis chart ^16 This maps to 6.2.7 at time of writing, inline with 6.2.6 in production - Add redis protocol env var with fallback of `rediss` - TLS Allows transaparent use of different protocol on UAT (`redis://`) as opposed to staging and production (`rediss://`). While enabling TLS for bitnami/redis is possible it requires generation and/or use of existing certificates. Plus since communication is within the cluster TLS is not required. - Configure the redis chart Use standalone architecture (only a master, no replicas) and Specify cpu and memory limits. These should ensure minimal resource consumption for branches and limit the number of pods/containers we are using.
Use a different redis host name depending on whether the
release name contains the name of the chart, "redis".
TODO: if cloud-platform-tools image is update to helm 3.7+, currently 3.6+
we could use a `Subcharts` references in a helper as below instead.
```yaml
{{/*
Function to return the name for a UAT redis chart master node host
*/}}
{{- define "apply-for-legal-aid.redis-uat-host" -}}
{{- $redis_fullName := (include "common.names.fullname" .Subcharts.redis) -}}
{{- $redis_cluster_domain := "cluster.local" -}}
{{- printf "%s-master.%s.svc.%s" $redis_fullName .Release.Namespace $redis_cluster_domain -}}
{{- end -}}
```
Decomplicate the `_envs` file and allows commenting on reason for conditional logic.
jsugarman
force-pushed
the
ap-4505/test-branch
branch
from
a983d15 to
803135d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Test fresh branch using redis chart on UAT
Relates to story
Relates to story
Checklist
Before you ask people to review this PR:
bundle exec rakegit rebase main.