Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-3809: Means assessment capital check your answers page #5864

Merged
merged 6 commits into from
Oct 23, 2023
Merged

AP-3809: Means assessment capital check your answers page #5864

merged 6 commits into from
Oct 23, 2023

Conversation

agoldstone93
Copy link
Contributor

@agoldstone93 agoldstone93 commented Oct 12, 2023 •
edited
Loading

What

Link to story

Update capital CYA pages for all journeys:

  • Make simple content changes
  • Move details into translation file to follow pattern for rest of the codebase
  • Use summary list component in _restrictions.html.erb
  • Sort out flow and state so there's no error when changing bank account amounts

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the ap-3809-means-assessment-capital-cya branch 13 times, most recently from 19f281a to 07644dc Compare October 18, 2023 14:28
@agoldstone93 agoldstone93 marked this pull request as ready for review October 18, 2023 14:39
@agoldstone93 agoldstone93 requested a review from a team as a code owner October 18, 2023 14:39
@agoldstone93 agoldstone93 added the ready for review Please review label Oct 18, 2023
colinbruce
colinbruce approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor observation but, otherwise, LGTM 👍

app/views/shared/check_answers/_restrictions.html.erb Outdated Show resolved Hide resolved
@colinbruce colinbruce added approved Approved by code reviewers and removed ready for review Please review labels Oct 19, 2023
@agoldstone93 agoldstone93 force-pushed the ap-3809-means-assessment-capital-cya branch 2 times, most recently from bea1f85 to 608e89d Compare October 19, 2023 15:32
@agoldstone93
AP-3809: simple content changes
555b545 
Move details into translation file to follow pattern for
rest of the codebase
@agoldstone93
AP-3809: Bank account section content changes
b07e146 
Update content in bank account section. Change
instances of "No" and "None" to match designs.
Update feature tests so they still pass.
@agoldstone93
AP-3809: Fix change link routing
a0ac51b
@agoldstone93
AP-3809: Use summary list component on _restrictions partial
53855cd
@agoldstone93
AP-3809: Update bank accounts on CYA page
e8cf17f 
Update content, change conditional displaying of
different bank accounts, removed now unused
method
@agoldstone93
AP-3809: Add safe navigation operator to client bank accounts
526ac29 
Add back in safe navigation operator. Update spec
to properly test for nil savings by adding trait
to test for when none_selected is true
@agoldstone93 agoldstone93 force-pushed the ap-3809-means-assessment-capital-cya branch from 608e89d to 526ac29 Compare October 23, 2023 10:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@agoldstone93 agoldstone93 merged commit f25db31 into main Oct 23, 2023
7 checks passed
@agoldstone93 agoldstone93 deleted the ap-3809-means-assessment-capital-cya branch October 23, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinbruce colinbruce colinbruce approved these changes

Assignees
No one assigned
Labels
approved Approved by code reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoldstone93 @colinbruce