Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop: address some RSpec/ExpectActual exclusions #5857

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

agoldstone93
Copy link
Contributor

@agoldstone93 agoldstone93 commented Oct 11, 2023

What

  • Remove partial that has not been referenced since AP-3678
  • Replace helper method with variable as now only used once.
  • Remove other exclusions
  • Lots of changes to .rubocop_todo.yml as it was regenerated

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the rubocop/rails-helper-instance-variables branch from 042fb0c to 55e75cd Compare October 12, 2023 07:42
@agoldstone93 agoldstone93 changed the title Rubocop: remove check_benefits_helper exclusion Rubocop: address some RSpec/ExpectActual exclusions Oct 12, 2023
@agoldstone93 agoldstone93 force-pushed the rubocop/rails-helper-instance-variables branch from 07befdf to 787f84d Compare October 12, 2023 08:04
@agoldstone93 agoldstone93 marked this pull request as ready for review October 12, 2023 12:08
@agoldstone93 agoldstone93 requested a review from a team as a code owner October 12, 2023 12:08
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

@colinbruce colinbruce added the approved Approved by code reviewers label Oct 13, 2023
Remove partial that has not been referenced since AP-3678.
Replace helper method with variable as now only used once.
Pass in instance variable rather than using in helper method
As instance variables are used within the parent_layout pattern
they have been left in
@agoldstone93 agoldstone93 force-pushed the rubocop/rails-helper-instance-variables branch from 5497f23 to 967326c Compare October 16, 2023 07:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@agoldstone93 agoldstone93 merged commit 1424909 into main Oct 16, 2023
@agoldstone93 agoldstone93 deleted the rubocop/rails-helper-instance-variables branch October 16, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants