Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployment URL for all static URL deployments #49

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add deployment URL for all static URL deployments #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87017d2
Add deployment URL for all static URL deployments
BenMillar-MOJ Oct 18, 2024
0fb7572
Set DEPLOYMENT_URL to not be required
BenMillar-MOJ Oct 18, 2024
a29f43f
Enable dynamic URL output from deploy-dev
BenMillar-MOJ Oct 18, 2024
9d93653
Merge branch 'main' into feature/Show-URL-as-output-from-deploy-job
BenMillar-MOJ Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/deploy-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ on:
jobs:
deploy:
name: Deploy
environment: ${{ inputs.environment }}
environment:
name: ${{ inputs.environment }}
url: ${{ env.DEPLOYMENT_URL }}
runs-on: ubuntu-latest
permissions:
id-token: write # This is required for requesting the JWT
Expand Down Expand Up @@ -71,6 +73,7 @@ jobs:
run: |
export CLEANED_BRANCH_NAME=$(echo ${BRANCH_NAME} | sed 's/^feature[-/]//' | sed 's:^\w*\/::' | tr -s ' _/[]().' '-' | tr '[:upper:]' '[:lower:]' | cut -c1-28 | sed 's/-$//')
export HOST_NAME=${CLEANED_BRANCH_NAME}-${DEV_HOST}
echo "DEPLOYMENT_URL=https://${HOST_NAME}" >> $GITHUB_ENV

helm upgrade ${CLEANED_BRANCH_NAME} \
${HELM_DIR} \
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ on:
ECR_REPOSITORY:
required: true
type: string
DEPLOYMENT_URL:
required: false
type: string
secrets:
ECR_REGISTRY:
required: true
Expand All @@ -29,7 +32,9 @@ on:
jobs:
deploy:
name: Deploy
environment: ${{ inputs.environment }}
environment:
name: ${{ inputs.environment }}
url: ${{ vars.DEPLOYMENT_URL }}
runs-on: ubuntu-latest
permissions:
id-token: write # This is required for requesting the JWT
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/feature-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ jobs:
environment: uat
ECR_REGION: ${{vars.ECR_REGION}}
ECR_REPOSITORY: ${{vars.ECR_REPOSITORY}}
DEPLOYMENT_URL: ${{vars.DEPLOYMENT_URL}}
secrets:
ECR_REGISTRY: ${{ secrets.ECR_REGISTRY }}
ECR_ROLE_TO_ASSUME: ${{ secrets.ECR_ROLE_TO_ASSUME }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/main-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ jobs:
environment: production
ECR_REGION: ${{vars.ECR_REGION}}
ECR_REPOSITORY: ${{vars.ECR_REPOSITORY}}
DEPLOYMENT_URL: ${{vars.DEPLOYMENT_URL}}
secrets:
ECR_REGISTRY: ${{ secrets.ECR_REGISTRY }}
ECR_ROLE_TO_ASSUME: ${{ secrets.ECR_ROLE_TO_ASSUME }}
Expand Down
Loading