Make record-arrival endpoint idempotent #2467
Merged
+61
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregkhawkins
force-pushed
the
feature/APS-1503__make_record_arrival_idempotent
branch
from
1b9a879
to
eda0419
Compare
gregkhawkins
commented
Nov 8, 2024
...lin/uk/gov/justice/digital/hmpps/approvedpremisesapi/service/cas1/Cas1SpaceBookingService.kt
Outdated
Show resolved
Hide resolved
davidatkinsuk
approved these changes
Nov 8, 2024
...in/uk/gov/justice/digital/hmpps/approvedpremisesapi/integration/cas1/Cas1SpaceBookingTest.kt
Outdated
Show resolved
Hide resolved
...uk/gov/justice/digital/hmpps/approvedpremisesapi/integration/asserter/DomainEventAsserter.kt
Outdated
Show resolved
Hide resolved
...lin/uk/gov/justice/digital/hmpps/approvedpremisesapi/service/cas1/Cas1SpaceBookingService.kt
Outdated
Show resolved
Hide resolved
gregkhawkins
force-pushed
the
feature/APS-1503__make_record_arrival_idempotent
branch
3 times, most recently
from
1f7a5d7
to
857b4d1
Compare
gregkhawkins
force-pushed
the
feature/APS-1503__make_record_arrival_idempotent
branch
from
857b4d1
to
98ca392
Compare
gregkhawkins
deleted the
feature/APS-1503__make_record_arrival_idempotent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
cas1SpaceBookingService.recordArrivalForBookingto return a success outcome if the requiredcas1NewArrival.arrivalDateTimematches the value already set onexistingCas1SpaceBooking.actualArrivalDateTime. If a value is already set and it doesn’t match the required value, return a conflict error as per the current behaviour.