Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go mean time to repair #6250

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Go mean time to repair #6250

merged 9 commits into from
Oct 9, 2024

Conversation

mikebell
Copy link
Contributor

@mikebell mikebell commented Oct 9, 2024

👀 Purpose

♻️ What's changed

  • Removes the old ruby code that generates the meant time to repair information
  • Add --- deliniation to make it easier to parse quarters in the incident log
  • Updated some wrong mean times to repair

Copy link
Contributor

@jaskaransarkaria jaskaransarkaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great working converting this script to Go 🎉 my comments are no-blocking suggestions. I want to get your thoughts on moving the script to the tools image? I'm aware we've got lots of scripts/ bins all over the place and with the conversion work going on it's a chance to centralise those disparate bits.

cmd/mean-time-to-repair/main.go Outdated Show resolved Hide resolved
cmd/mean-time-to-repair/main.go Outdated Show resolved Hide resolved
cmd/mean-time-to-repair/main.go Outdated Show resolved Hide resolved
cmd/mean-time-to-repair/main.go Outdated Show resolved Hide resolved
cmd/mean-time-to-repair/main.go Outdated Show resolved Hide resolved
cmd/mean-time-to-repair/main.go Outdated Show resolved Hide resolved
@mikebell mikebell merged commit 2a6d679 into main Oct 9, 2024
2 of 3 checks passed
@mikebell mikebell deleted the go-mean-time-to-repair branch October 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🥇 Done
Development

Successfully merging this pull request may close these issues.

2 participants