Replace existing method of obtaining standing data with SDRS API call #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old method of creating, updating and maintaining our standing data. Previously we used Puppeteer to interact with a browser to download the data.
This PR allows us to retire the old method and call the SDRS API maintained by CGI, calling the
getOffence
endpoint to get an up to date json object of offence codesstanding-data-api-offences.json
. This file is the equivalent ofpnld-offences.json
which is produced using the old method.We have decided to omit a few keys as they seemed unnecessary/unused
This PR also removes reference to the method of creating the other file
cjs-offences.json
that was processed at the same time when we produces the old input filepnld-offences.json
. We get all the data from the new API call so have removed as redundant.