Missing minio service name #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to mention in example, credits to @allanrogerr Signed-off-by: pjuarezd <[email protected]>
allanrogerr
approved these changes
Aug 9, 2024
cesnietor
approved these changes
Aug 9, 2024
| @@ -307,7 +307,7 @@ minio.<namespace> | |||
| minio.<namespace>.svc | |||
| minio.<namespace>.svc.<cluster domain> | |||
| *.<tenant-name>-hl.<namespace>.svc.<cluster domain> | |||
| *.<namespace>.svc.<cluster domain> | |||
| *.minio.<namespace>.svc.<cluster domain> | |||
There was a problem hiding this comment.
@pjuarezd @allanrogerr It's a good idea to remove *.<namespace>.svc.<cluster domain> from the certificate. But why add *.minio.<namespace>.svc.<cluster domain>? The minio service is not a headless service, so it will always be addressed using minio.<namespace>.svc.<cluster domain> (already in the certificate). Only headless services need a wildcard domain...
PS: I think *.<tenant-name>.minio.<namespace>.svc.<cluster domain> on line 311 is obsolete too. You can't have services that have this amount of dots before the <namespace>.svc.<cluster domain>...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to mention in example, credits to @allanrogerr