Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minioJob support minio disable tls #2256

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Aug 6, 2024

fix: minioJob support minio disable tls

add support not tls
@jiuker jiuker requested review from ramondeklein, dvaldivia, shtripat, pjuarezd and cniackz and removed request for ramondeklein August 6, 2024 12:57
@jiuker jiuker changed the title fix: minioJob support not tls fix: minioJob support minio not tls Aug 6, 2024
@jiuker jiuker changed the title fix: minioJob support minio not tls fix: minioJob support minio disable tls Aug 6, 2024
pkg/utils/miniojob/types.go Outdated Show resolved Hide resolved
pkg/utils/miniojob/types.go Outdated Show resolved Hide resolved
apply suggestion
@jiuker jiuker requested a review from ramondeklein August 7, 2024 01:12
pjuarezd
pjuarezd previously approved these changes Aug 7, 2024
ramondeklein
ramondeklein previously approved these changes Aug 7, 2024
pkg/utils/miniojob/types.go Outdated Show resolved Hide resolved
apply suggestion
@jiuker jiuker dismissed stale reviews from ramondeklein and pjuarezd via c4ceb8d August 8, 2024 00:58
@jiuker jiuker requested review from ramondeklein and pjuarezd August 8, 2024 00:59
@pjuarezd pjuarezd merged commit 67f4e6c into minio:master Aug 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants