Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change as field is actually needed #1821

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Oct 16, 2023

Objective:

To add back namespace field as is needed

When is needed:

When installing Operator/Tenant via ArgoCD with a mix of Helm and Kustomization.

Original Change:

Example when is needed:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - minio-operator/minio-operator-ns.yaml
helmCharts:
  - name: operator
    repo: https://operator.min.io/
    version: v5.0.9
    releaseName: minio-operator
    namespace: minio-operator

Documentation:

@cniackz cniackz self-assigned this Oct 16, 2023
@cniackz cniackz added the bug Something isn't working label Oct 16, 2023
@cniackz
Copy link
Contributor Author

cniackz commented Oct 16, 2023

@dnskr, we appreciate your pull request. After further investigation, we've discovered that this field is not redundant as originally assumed. In fact, there is a specific use case where it is essential. We will work on documenting this approach to ensure clarity for you and others. Consequently, we are reinstating this field since it has been determined to be necessary. Thank you for your understanding and your contribution!

@cniackz cniackz requested a review from shtripat October 16, 2023 20:53
@dnskr
Copy link
Contributor

dnskr commented Oct 16, 2023

@cniackz Thank you for letting me know. I have never used Helm -> Kustomize -> ArgoCD chain, so I haven't expirienced the issue. It's an interesting case. I would expect it to be managed by ArgoCD properly. Or is it Kustomize limitation?

@kannappanr kannappanr merged commit 65d1502 into minio:master Oct 16, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants