Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetBucketLocation API does not require path-style addressing in AWS S3 #1430

Closed
wants to merge 2 commits into from
Closed

GetBucketLocation API does not require path-style addressing in AWS S3 #1430

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a248b4
The GetBucketLocation API does not require path-style addressing in A…
lentitude2tk Jul 16, 2024
6895af0
Merge branch 'master' into fix_enforce_path_style
harshavardhana Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions minio/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,9 +715,6 @@ def build(
# CreateBucket API requires path style in Amazon AWS S3.
(method == "PUT" and not object_name and not query_params) or

# GetBucketLocation API requires path style in Amazon AWS S3.
(query_params and "location" in query_params) or

# Use path style for bucket name containing '.' which causes
# SSL certificate validation error.
("." in bucket_name and self._url.scheme == "https")
Expand Down