Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for operations on Tencent COS #1429

Closed

Conversation

lentitude2tk
Copy link

No description provided.

@harshavardhana
Copy link
Member

We have stopped adding new endpoints in this manner as native endpoints.

There are no reasons to have this.

@lentitude2tk
Copy link
Author

We have stopped adding new endpoints in this manner as native endpoints.

There are no reasons to have this.

Currently, the minio-java-sdk provides the enableVirtualStyleEndpoint method, and the milvus-go-sdk offers the BucketLookup=BucketLookupDNS method, both of which can be dynamically configured externally to support this. However, the minio-python-sdk has not yet exposed this capability externally. Are there no plans to align this functionality with the java and go SDKs in the future?

@balamurugana
Copy link
Member

Can't you use

def enable_virtual_style_endpoint(self):
?

@lentitude2tk
Copy link
Author

@balamurugana
This is my mistake; I didn't notice this method. I can indeed use the enable_virtual_style_endpoint. However, I observed that this setting is not the highest priority. When constructing the BaseUrl, minio enforces the use of pathStyle based on certain parameters' interface behavior. Is there an existing method to avoid this?

if enforce_path_style or not self._virtual_style_flag:

@harshavardhana
Copy link
Member

@lentitude2tk this the part that needs to be fixed, feel free to send a PR

@lentitude2tk
Copy link
Author

@lentitude2tk this the part that needs to be fixed, feel free to send a PR

Sure, thank you for your reply.

@lentitude2tk
Copy link
Author

@lentitude2tk this the part that needs to be fixed, feel free to send a PR

I have resubmitted a PR to remove the invalid PathStyle setting #1430. I reviewed the code of minio-java-sdk, which also includes this check, but it doesn't actually pass the queryParameter, so this part of the logic doesn't work. However, it doesn't affect functionality.

https://github.com/minio/minio-java/blob/245f63d385cc9c58c75696da85eaf19933746d6c/api/src/main/java/io/minio/MinioAsyncClient.java#L1389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants