feat: port support string type #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this PR be merged? @prakashsvmx |
kaankabalak
approved these changes
Nov 15, 2024
prakashsvmx
approved these changes
Nov 16, 2024
|
Thank you for the contribution @sapenlei |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want the port to support string type for two reasons:
Many well-known libraries support both string and number for port configuration, since ports are typically loaded from env files where values are strings. This way, users don't need to perform type conversion.
Many people, including myself, find that when the port is passed as a string type, the error message is not very clear, only showing "invalid port".