Latest Shiori integration API update #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiesselune
changed the title
tiesselune
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Pull request motivation
Shiori is udating its API to make it RESTful and is adopting the new endpoints gradually. The Login/Auth flow has changed, and the old API is not available in latest stable Shiori (at the time, 1.7.1), making the integration fail to login with a 404 error.
This pull request fixes #2074 with Shiori 1.7.1
This Pull Request updates the auth flow in the Shiori integration with new API endpoints and new fields in the API.
This version works against latest stable Shiori API.
Please note : Unfortunately, the
/api/bookmarksPOST API has not been migrated yet, and another pull request will be necessary if/when the old API is removed. Until then, this pull request fixes the current Shiori integration.