added setWinner #22

minhd-vu · Feb 15, 2021 · f481bde · f481bde
1 parent d3955fe
commit f481bde
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/server/helpers/setWinner.js b/server/helpers/setWinner.js
@@ -0,0 +1,14 @@
+module.exports = async function setWinner(user, target) {
+    const isWinner = user._id.toString() === target.toString()
+
+    if (isWinner) {
+        user.stats.wins++;
+        user.target = null;
+        user.party.isStarted = false;
+        user.party.winner = user._id;
+        await user.party.save();
+    }
+
+    return isWinner;
+}
+
diff --git a/server/routes/assassinate/confirm.js b/server/routes/assassinate/confirm.js
@@ -2,6 +2,7 @@ const router = require("express").Router();
 const isLoggedIn = require("../../helpers/isLoggedIn");
 const User = require("../../models/user.model");
 const shuffle = require("../../helpers/shuffle");
+const setWinner = require("../../helpers/setWinner");
 
 router.route("/").get(isLoggedIn, async function (req, res) {
     if (req.user.isPending) {
@@ -25,13 +26,7 @@ router.route("/").get(isLoggedIn, async function (req, res) {
 
             switch (user.party.gameMode) {
                 case "Classic":
-                    if (user._id.toString() === target.toString()) {
-                        user.stats.wins++;
-                        user.target = null;
-                        user.party.isStarted = false;
-                        user.party.winner = user._id;
-                        await user.party.save();
-                    } else {
+                    if (!setWinner(user, target)) {
                         user.target = target;
                     }
                     break;
@@ -46,6 +41,7 @@ router.route("/").get(isLoggedIn, async function (req, res) {
                         }
                         player.save();
                     });
+                    setWinner(user, target);
                     break;
             }