Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carts: Get rid of animation hack #2958

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

appgurueu
Copy link
Contributor

@appgurueu appgurueu commented Jun 1, 2022

Fixes #2950; also fixes the visual aspect of #1927 - the player is now rotated:

Rotated player

  • offset the entity by +0.5 if rotated; as a bonus, this will also fix the previous incorrectly offset selection box

@appgurueu appgurueu marked this pull request as draft June 1, 2022 18:16
@sfan5
Copy link
Member

sfan5 commented Jun 1, 2022

I just wanted to give this my approal 🤔

Unrelated some smooth animation would be nice in the future, poor Sam must have a headache after riding such a track:
one

@SmallJoker
Copy link
Member

SmallJoker commented Jun 2, 2022

After the offset is added this will look definitely better than the current one. The patch is surprising simple.

@sfan5 The rotation (of the cart) is actually interpolated client-side. It's just rather fast. It can also be observed when punching a cart into the other direction due to the direction <---> yaw connection. https://github.com/minetest/minetest/blob/9fc018ded10225589d2559d24a5db739e891fb31/src/client/content_cao.cpp#L1133

@sfan5
Copy link
Member

sfan5 commented Apr 8, 2023

What's the status here?

@appgurueu
Copy link
Contributor Author

What's the status here?

Not finished. I remember this not being as easy as applying the appropriate offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cart: Get rid of animation hack
3 participants