Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial rename of Minetest to Luanti #311

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Conversation

rollerozxa
Copy link
Member

@rollerozxa rollerozxa commented Oct 24, 2024

Renames most occurences of Minetest on the landing page to Luanti.

Some occurences have been left alone such as mentions to press resources that haven't been renamed yet. I left them not renamed as a reminder.

A "(formerly Minetest)" is added to the title of the index page.

I also added a note on the download page to reduce any confusion before 5.10.0 is out and the rename comes to the engine, so it can be merged right away:

image

Bikeshedding Feedback on the phrasing welcome, but I assume it can also be removed once 5.10.0 comes out which would be soon.

Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks fine. I've looked for occurrences where a rename might have been missed, but the vast majority are links that can't be updated yet.

_data/press.yml:    para: A flyer to promote Minetest.
_data/press.yml:    para: A leaflet to promote Minetest in Education.
_data/press.yml:    para: A showcase of the content Minetest has to offer.

though it is probably fine to leave them as-is for now since they (well, except for the last one) refer to past engine versions and are more consistent with the material this way.

@sfan5
Copy link
Member

sfan5 commented Oct 28, 2024

I also added a note on the download page to reduce any confusion before 5.10.0 is out and the rename comes to the engine, so it can be merged right away:

Maybe we should just merge this right before the 5.10 release then?

Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Maybe we should just merge this right before the 5.10 release then?

Question is how problematic it is to have the website be outdated (and thus also somewhat unsuitable for luanti.org) in the meantime. I'd be in favor of merging this now.

@rollerozxa
Copy link
Member Author

I was thinking this would be merged right away so the landing page could be moved to luanti.org, but if there will be a release in a couple days I guess it wouldn't matter.

@rollerozxa
Copy link
Member Author

I was hoping this would be merged like a week ago so we could have everything ready for the release, but I guess we're doing everything at once instead.

@sfan5 sfan5 merged commit af44d7e into minetest:master Nov 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants