WIP: Add Group ownership #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedrichaase
force-pushed
the
groups
branch
3 times, most recently
from
54bded2 to
c78bf14
Compare
Panquesito7
reviewed
Oct 16, 2019
| @@ -0,0 +1 @@ | |||
| usergroups | |||
There was a problem hiding this comment.
depends.txt is deprecated, use mod.conf instead.
|
Needs rebase. |
I was going to say that. 😉 |
|
Abandoned PR. Closing until someone would like to pick it up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #4, should also solve #14 (if used accordingly)
Adds a dependency to: https://github.com/cedrichaase/usergroups
This is just a proof of concept for now, posted for review
Basic functionality is implemented and working, but group ownership may introduce some problems I'm not aware of.
I've used a new area.group field to indicate group ownership, though, as of now, the "owner" field of an area is generally expected to be present and filled with a string that contains a user name.