-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement block iterator #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
database/Sql.Rows.Close() should be called as it is a safe to call and idempotent; not calling it will keep the underlying connection open. Added an integration test to reproduce the issue and a fix to it. Fixes minetest-go#53
The iterator returns a go channel to allow for concurrent access over all the data in the map, skipping any non-existing blocks. Fix minetest-go#55
Pull Request Test Coverage Report for Build 4237033961
💛 - Coveralls |
ronoaldo
commented
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good! Just a few important QOL changes, as well as better testing.
Fixed an infinite loop/invalid results returned by the Iterator if database/data is corrupted.
Implemented the Closer type and methods to allow for callers to early stop the iteretor when they're done.
Ready for review/comments! I am planning to use this to perhaps allow parallel execution of the Export and Clean implementations of https://github.com/minetest-go/mapcleaner |
BuckarooBanzay
approved these changes
Nov 28, 2023
nice, lgtm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
Todo: