feat: extend export with protected nodes defined by user. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from minetest-go#181
Gracefully flushes the remaining transactions for Sqlite. Requires new release of minetest-go/mtdb. Fixes minetest-go#180
ronoaldo
changed the title
Avoid losing data when protected nodes are at the mapblock/mapchunk edges.
Nasty loops!
Accounting for two neighbor chunks and the surrounding being exported when --export-all is provided.
|
Ready to review / merge! I have tested this on my own server, and the exported regions with --export-all reflect what would be left when you run --prune_unprotected. It was fully working on a 80G map with 125.000.000+ mapblocks, exporting a 4G working sqlite map. This actually provides a nice and safe way to clean the map as the resulting and smaller version can be checked before it goes live. |
BuckarooBanzay
approved these changes
Dec 7, 2023
|
Nice! Yeah, on my case, there are huge builds. Like an enormous tunnel with 18km of distance (in game distance), a giga factory with automations galore and several player bases around the world. However, the majority of places were just mapgen stuff with no protected regions so the reduced size was significant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.