Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coordinates calc for negative positions #182

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

ronoaldo
Copy link
Contributor

This also removes the offset for mapchunks,
was also causing issues when exporting.

Fixes #181

This also removes the offset for mapchunks,
was also causing issues when exporting.

Fixes minetest-go#181
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7037167427

  • 4 of 20 (20.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 1.361%

Changes Missing Coverage Covered Lines Changed/Added Lines %
util.go 4 8 50.0%
export.go 0 12 0.0%
Totals Coverage Status
Change from base Build 6913197380: 1.4%
Covered Lines: 6
Relevant Lines: 441

💛 - Coveralls

@BuckarooBanzay
Copy link
Member

thanks, i'll check out the test-failures after the merge 👍

@BuckarooBanzay BuckarooBanzay merged commit 3aa2dbe into minetest-go:master Nov 30, 2023
2 of 3 checks passed
@ronoaldo ronoaldo deleted the ronoaldo/issue181 branch November 30, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinates calculation is off for negative positions (nodes -> mapblocks -> mapchunks)
3 participants