Update/mixinextras expressions #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Suppress `ReferenceToMixin` for `@Dynamic` * Fix formatting for `MixinClassCannotBeReferencedSuppressor` * Move logic to `MixinClassReferenceInspection`
Following fabric-example-mod change for 1.20.5
… in (minecraft-dev#2293) * * fix dynamic selector missing namespace when the selector declares it at registration * allow dynamic selectors to change the target class that is used when looking up members * move custom owner over to mixin selector
Mappings don't work currently, the TSRG file seems to contain indices to an array in another JSON file?
- Recognize entrypoints declared in object form - Add more conditions to the inspection - Add some tests to cover the inspection Fixes minecraft-dev#2296
…tras-expression # Conflicts: # src/main/kotlin/platform/mixin/handlers/mixinextras/WrapOperationHandler.kt
LlamaLad7
force-pushed
the
update/mixinextras-expressions
branch
2 times, most recently
from
9f34cd2 to
f150845
Compare
LlamaLad7
force-pushed
the
update/mixinextras-expressions
branch
from
f150845 to
d8a9f83
Compare
…erface`. It's quite scuffed and often returns `Object` even when there is a suitable common interface, but what's important is that this matches the runtime logic.
LlamaLad7
force-pushed
the
update/mixinextras-expressions
branch
from
a78c1fa to
c88fd70
Compare
Earthcomputer
approved these changes
Jul 3, 2024
Earthcomputer
merged commit f652895
into
minecraft-dev:mixinextras-expression
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in dev and makes some minor changes to keep up with refactors.
Also creates an
MEExpressionService.