Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iframe): 新增iframe菜单缓存,切换tab时不再重新加载第三方网页 #465

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

kanyxmo
Copy link
Member

@kanyxmo kanyxmo commented Nov 20, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new store for managing iframes, allowing dynamic handling of multiple iframe instances based on routing.
    • Enhanced the menu-form component with additional fields and improved interactivity for managing menu items.
    • Updated internationalization support with new translations for user profile settings.
  • Improvements

    • Streamlined avatar update logic to enhance user experience.
    • Refined routing logic to improve caching behavior for iframe routes.
  • Bug Fixes

    • Removed unnecessary console log statements for cleaner component behavior.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 20, 2024
Copy link

coderabbitai bot commented Nov 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve multiple components across the application, primarily focusing on enhancing functionality and simplifying code. Key modifications include the removal of console log statements in the MineSystemError and MainAside components, the introduction of a new useIframeKeepAliveStore for managing iframe states, and updates to the MineIframe component to handle multiple iframes based on routing. Additionally, the menu-form.vue component has been significantly enhanced with new properties and methods for improved menu management.

Changes

File Path Change Summary
web/src/layouts/[...all].tsx Removed console log statement in MineSystemError; rendering logic remains unchanged.
web/src/layouts/components/iframe/index.tsx Updated MineIframe to render multiple iframes based on routing, replacing single conditional rendering with a mapping over iframeStore.iframeList.
web/src/layouts/components/main-aside/index.tsx Removed console log statement in onAsideScroll; scroll logic remains intact.
web/src/layouts/index.tsx Added import for MineIframe; updated rendering logic to exclude components of type 'I' when keepAliveStore.getShowState() is true.
web/src/modules/base/views/permission/menu/menu-form.vue Enhanced form functionality with new methods and properties for menu management; improved data handling and rendering logic.
web/src/modules/base/views/uc/index.vue Updated i18n strings for user interface; modified avatar update logic and removed console log statement.
web/src/router/index.ts Introduced iframeKeepAliveStore for managing route caching; updated router.afterEach hook for specific route types.
web/src/store/modules/useIframeKeepAliveStore.ts Created a new store for managing iframes with functions to add, remove, and clean iframe entries.
web/src/store/modules/useRouteStore.ts Modified menuToRoutes function to change iframe route path from /maIframe/${item.name} to /MineIframe/${item.name}.
web/types/auto-imports.d.ts Added auto-import for useIframeKeepAliveStore to global scope.

Possibly related PRs

Suggested labels

size:L

🐰 In the code, I hop and play,
Removing logs to clear the way.
With iframes now, we dance and glide,
A smoother path, a joyful ride!
Menu forms with tags that shine,
In this code, all's now divine! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kanyxmo kanyxmo merged commit 1b79b76 into master Nov 20, 2024
21 of 23 checks passed
@dosubot dosubot bot added the enhancement label Nov 20, 2024
@kanyxmo kanyxmo deleted the feat(iframe) branch November 20, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant