Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this is the first PR of WWZ team! #96

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Shmtu-Herven
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind task

/kind feature

What does this PR do / why do we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewers:

@mindspore-bot
Copy link
Contributor

Welcome @Fengjuzhuwhw!

It looks like this is your first PR to mindspore-ai/mindspore 🎉.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if mindspore-ai/mindspore has its own contribution guidelines. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to MindSpore. 😃

@mindspore-bot
Copy link
Contributor

Hi @Fengjuzhuwhw. Thanks for your PR.

I'm waiting for a mindspore-ai member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Stevengu999
Copy link

W00wssoooow!!!

return PyCapsule_New(ctypes.byref(dl_managed_tensor), b'dltensor', None)

## dlpack to numpy.array
def numpy_from_dlpack(pycapsule):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add from_dlpack(pycapsule) method to implement dlpack to mindspore.Tensor.

from mindspore import Tensor
import numpy as np
def tensor_from_numpy(data_numpy):
return Tensor(data_numpy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to have a check with the type data_numpy with the below:

if not isinstance(data_numpy, np.array):
    panic()

@leonwanghui
Copy link
Contributor

/ok-to-test

@Shmtu-Herven
Copy link
Author

Thinks a lot ! we will recheck it.

this is the second PR of WZZ team!
@Shmtu-Herven
Copy link
Author

this is the second PR of WZZ team!

@mindspore-bot
Copy link
Contributor

@Fengjuzhuwhw: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
shellcheck 553bb6e link /test shellcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants