add one more condition for data querying to limit the end of date field #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use it for prometheus remote read, we met an issue that if we query data in a period long ago, it will cost such a long time to get the result.
Through the log, we found out that the query condition is as below:
"date >= toDate(1574999700) AND ts >= toDateTime(1574999700) and ts <= toDateTime(1575021600)"
But since the table should be partitioned by date, so, such query condition will seach all records from the start point till now.
So I made this change to make the query condition as below to guarantee clickhouse just search records in the specified range:
"date >= toDate(1574999700) AND ts >= toDateTime(1574999700) and ts <= toDateTime(1575021600) and date<=toDate(1575021600)"