Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue #211 #214

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes for issue #211 #214

wants to merge 3 commits into from

Conversation

AsmaTANABEN
Copy link
Collaborator

@AsmaTANABEN AsmaTANABEN commented Nov 21, 2024

Adjust normalization of density compensation coefficients and adding Cufinufft Pipe function authored by Chaithya G.R.
Resolves #211

…. Add Cufinufft Pipe function authored by Chaithya G.R.
Copy link
Member

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we have some tests as well ?

@chaithyagr
Copy link
Member

I would strongly recommend adding the changes for cufinufft in #195 as it is tested there. Also, that will allow this PR to be merged smoothly without waiting for finufft/cufinufft releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent density-compensation normalization leading to signal instability
3 participants