Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving benchmark experience2.0 #5

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Lenoush
Copy link
Contributor

@Lenoush Lenoush commented Oct 2, 2024

PR who solve :

Fix :

  • save Dataframe into csv each time you create perf analysis (png)
  • explain the readme with hydra ( delete auto_benchmark_perf.py )
  • new graph ( cuda11, cuda12 with new cu finufft install with pip, cuda12 with new cu finufft install DiamonDinoia recommandation)
  • old graph with new visualisation
  • add tensorlfow

Still fixing:

  • when out of memory , plot something

@Lenoush Lenoush self-assigned this Oct 2, 2024
@Lenoush Lenoush marked this pull request as draft October 2, 2024 08:58
Copy link
Member

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements !

A comment on the results: cufinufft with pip install seems to work significantly better than the --no-binary installation. Do you have any comments on that ?

30_perf_analysis.py Outdated Show resolved Hide resolved
30_perf_analysis.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Lenoush
Copy link
Contributor Author

Lenoush commented Oct 2, 2024

The pip installation doesn't work better, it just fatser.
The --no-binary installation may be slower but it uses less memory.

and Finufft with the --no-binary installation use GPU mem

@paquiteau
Copy link
Member

and Finufft with the --no-binary installation use GPU mem

Wut ? This should not be the case. You probably ran finufft after cufinufft in your benchmark, and did not clear the memory (launch it in a new process to be sure)

@DiamonDinoia
Copy link

I did notice that finufft (cpu only) got quite a bit faster. Is that my impression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants