-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving benchmark experience2.0 #5
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements !
A comment on the results: cufinufft with pip install seems to work significantly better than the --no-binary installation. Do you have any comments on that ?
The pip installation doesn't work better, it just fatser. and Finufft with the --no-binary installation use GPU mem |
Wut ? This should not be the case. You probably ran finufft after cufinufft in your benchmark, and did not clear the memory (launch it in a new process to be sure) |
I did notice that finufft (cpu only) got quite a bit faster. Is that my impression? |
PR who solve :
Fix :
Still fixing: