PIBD - Revert earlier pibd_aborted flag in sync logic #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeastplume
changed the title
|
Have tested now, this fixes #3754. The SyncStatus struct essentially keeps track of a large state machine which is executed every tick (essentially getting reset) in order to determine what the state of sync should be. A separate |
tromp
reviewed
Jun 22, 2023
| @@ -62,6 +64,12 @@ impl StateSync { | |||
| self.earliest_zero_pibd_peer_time = t; | |||
| } | |||
|
|
|||
| /// Flag to abort PIBD process within StateSync, intentionally separate from `sync_state`, | |||
| /// which can be reset between calls | |||
| pub fn set_pibd_aborted(&mut self) { | |||
There was a problem hiding this comment.
abort_pid() seems like a more straightforward name
tromp
approved these changes
Jun 22, 2023
|
Thanks for reviewing! |
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 23, 2024
mimblewimble#3757) * revert earlier pibd_aborted flag in sync logic * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts StateSync's
pibd_abortedflag, to test whether it fixes PIBD appearing to resume after having fallen back to txhashset.zip download.Also includes changes #3756 (will merge that separately if all tests go well here)