-
Notifications
You must be signed in to change notification settings - Fork 84
Conversation
Welcome @lowener! It looks like this is your first PR to milvus-io/knowhere 🎉 |
@lowener Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
thanks for contribute the code, |
Conda is the preferred way to get libraft usually. Since conda is not being used right now I found an alternative with pip through the pylibraft package. |
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
3ce01b0
to
439aee2
Compare
@lowener Essentially, we are using knowhere more as a c++ library, and if he needs to rely on the python environment, it will be troublesome for us in the vast majority of cases. |
@lowener This pr is excellent and I would accept it if you remove the HINT_LIBRAFT related code. thank you. |
50bd153
to
a7575e6
Compare
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
a7575e6
to
27c2fe1
Compare
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowener, Presburger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR changes the raft ivf function calls from raw pointer to mdspan. These functions are pre-compiled in libraft so it will speed up the compile time.
To receive the latest libraft release, it is recommended to use conda package manager:
I'm open for suggestions on how to handle installing conda and linking to libraft.
issue: #857