Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added different upsampling-modes #357

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kielnino
Copy link

Instead of the fixed bilinear upsample, I added a mode-parameter to switch between upsample, unpool, transpose.

@kielnino
Copy link
Author

I realised, that I have to update the train script too. I need to get used to the argparse with choices first, so I will update the file as soon as I got it working correctly.

@kielnino
Copy link
Author

Okay, I think it should work now.

@Gouvernathor
Copy link
Contributor

Gouvernathor commented Apr 14, 2022

This should still support the --bilinear CLI argument. Having it set the upsampling-mode to 'bilinear' should be enough.
And in that case its docstring should probably read "deprecated, use upscaling_mode bilinear instead".

@kielnino
Copy link
Author

@Gouvernathor You are right. I've updated train.py and predict.py

@kielnino
Copy link
Author

@milesial Is there anything else I can/must adjust to get the PR approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants