Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't destroy engine when current file is outside project before tryi… #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't destroy engine when current file is outside project before tryi… #1

wants to merge 2 commits into from

Conversation

alefeve
Copy link

@alefeve alefeve commented Nov 15, 2018 •
edited
Loading

but instead, try to get an environment (use pick_environment hook)

@alefeve alefeve self-assigned this Nov 15, 2018
@alefeve alefeve requested review from aoblet and eprana November 15, 2018 12:10
@eprana
Copy link

eprana commented Nov 15, 2018

LGTM

aoblet
aoblet reviewed Nov 15, 2018
View reviewed changes
Copy link

@aoblet aoblet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. Why do we need in tk-houdini to check the current scene periodically with a specific interval.

_on_file_change_timeout is connected to a QTimer.

python/tk_houdini/ui_generation.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoblet aoblet aoblet approved these changes

@eprana eprana eprana approved these changes

Assignees

@alefeve alefeve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alefeve @eprana @aoblet