Skip to content

Commit

Permalink
fix: no hiding
Browse files Browse the repository at this point in the history
the hidden attribute is for accessiblity and machines. No need to remove
  • Loading branch information
miklb committed Jul 12, 2024
1 parent 4ea7b81 commit 5e56297
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pull-quote.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,11 @@ class PullQuote extends HTMLElement {
}

connectedCallback() {
// Show the pullquote
this.root.querySelector('.pullquote').removeAttribute('hidden');

}

disconnectedCallback() {
// Hide the pullquote
this.root.querySelector('.pullquote').setAttribute('hidden', 'true');

}

/**
Expand Down

0 comments on commit 5e56297

Please sign in to comment.