Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for test breakdown per worker #3

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

NellyWhads
Copy link
Contributor

@NellyWhads NellyWhads commented Apr 16, 2024

  • Update docs to use same example as pytest (can be made more elaborate upon request)
  • Add configuration for two new modes: summary and breakdown
  • Unify testing procedures
  • Remove worker name (gw*) parsing logic, since worker names can be overridden: Naming the workers pytest-dev/pytest-xdist#737

@mikicz
Copy link
Owner

mikicz commented Apr 16, 2024

Oooh cool! Could you fix the tests and then I shall have a proper look?

@NellyWhads
Copy link
Contributor Author

Done!

Copy link
Owner

@mikicz mikicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only suggestion I made was a larger increase to the version

pyproject.toml Outdated Show resolved Hide resolved
pytest_xdist_worker_stats/__init__.py Outdated Show resolved Hide resolved
pytest_xdist_worker_stats/options.py Show resolved Hide resolved
@NellyWhads
Copy link
Contributor Author

Bumped, improved some test scope, and I think it's ready?

Got any other feature you've had on your mind I can knock out? 💻

@mikicz mikicz merged commit 8e252a0 into mikicz:main Apr 16, 2024
11 checks passed
@mikicz
Copy link
Owner

mikicz commented Apr 16, 2024

Thanks! I've triggered the deployment to PyPI

I have not been using this much since I wrote it, and haven't got anything major that I would like to add here - but if you want more features here, happy to review them and include them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants