Skip to content

Commit

Permalink
add test for 'Extractor.initialize()' (#4359)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikf committed Jul 28, 2023
1 parent 2bcf0a4 commit 255d08b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
3 changes: 1 addition & 2 deletions gallery_dl/extractor/mangahere.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ class MangahereMangaExtractor(MangahereBase, MangaExtractor):
("https://m.mangahere.co/manga/aria/"),
)

def __init__(self, match):
MangaExtractor.__init__(self, match)
def _init(self):
self.cookies.set("isAdult", "1", domain="www.mangahere.cc")

def chapters(self, page):
Expand Down
7 changes: 5 additions & 2 deletions gallery_dl/extractor/tumblr.py
Original file line number Diff line number Diff line change
Expand Up @@ -442,10 +442,13 @@ class TumblrDayExtractor(TumblrExtractor):
def __init__(self, match):
TumblrExtractor.__init__(self, match)
year, month, day = match.group(4).split("/")
self.date_min = ts = (
self.date_min = (
# 719163 == date(1970, 1, 1).toordinal()
date(int(year), int(month), int(day)).toordinal() - 719163) * 86400
self.api.before = ts + 86400

def _init(self):
TumblrExtractor._init(self)
self.api.before = self.date_min + 86400

def posts(self):
return self.api.posts(self.blog, {})
Expand Down
10 changes: 9 additions & 1 deletion test/test_extractor.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,16 @@ def test_unique_pattern_matches(self):
else:
self.assertIs(extr1, matches[0][1], url)

def test_init(self):
"""Test for exceptions in Extractor.initialize(()"""
for cls in extractor.extractors():
for test in cls._get_tests():
extr = cls.from_url(test[0])
extr.initialize()
break

def test_docstrings(self):
"""ensure docstring uniqueness"""
"""Ensure docstring uniqueness"""
for extr1 in extractor.extractors():
for extr2 in extractor.extractors():
if extr1 != extr2 and extr1.__doc__ and extr2.__doc__:
Expand Down

0 comments on commit 255d08b

Please sign in to comment.