Use simpler golangci-lint configuration; enable defaults and gosec

mikerhodes · Jun 5, 2023 · cb9670b · cb9670b
1 parent 0f90f1e
commit cb9670b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 46 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -3,59 +3,16 @@
 run:
   timeout: 5m
 
-output:
-  format: checkstyle
-
 linters:
-  # please, do not use `enable-all`: it's deprecated and will be removed soon.
-  # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
   disable-all: true
   enable:
-    # re-enable defaults
-    # - govet
-    # - errcheck
-    # - staticcheck
-    # - unused
-    # - gochecknoinits
-    # - gosimple
-    # - structcheck
-    # - varcheck
-    # - ineffassign
-    # - deadcode
-    # - typecheck
-    # - interfacer
-    # enable others
-    - bodyclose
-    - deadcode
-    - depguard
-    - dogsled
-    - dupl
-    - errcheck
-    - goconst
-    - gocritic
-    - gocyclo
-    - gofmt
-    - goimports
-    - golint
-    - gomnd
-    - goprintffuncname
+    # Add gosec
     - gosec
+    # Defaults per 1.52.2
+    - errcheck
     - gosimple
     - govet
     - ineffassign
-    - nakedret
-    - nolintlint
-    - scopelint
     - staticcheck
-    - structcheck
     - typecheck
-    - unconvert
-    - unparam
     - unused
-    - varcheck
-    - whitespace
-
-linters-settings:
-  gofmt:
-    # VSCode uses goreturns by default which doesn't support -s/simplify
-    simplify: false
diff --git a/Makefile b/Makefile
@@ -10,3 +10,6 @@ build:
 
 test:
 	go test ./...
+
+lint:
+	golangci-lint run
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,3 +10,6 @@ build: @@
     test:
     	go test ./...
+    lint:
+    	golangci-lint run