Handle incomptible encodings in email headers #1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running this new test case would throw an
Encoding::CompatibilityError
error, as it attempts to join the parsed ASCII-8BIT string and parsed UTF-8 string together.Now, if a set of incompatible encodings is detected, we first force the strings to be UTF-8, and replace invalid characters.
Let me know if there are other thoughts on how to handle this error.