Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP, experimental: Try merging small cells into neighbouring cells #9

Open
wants to merge 1 commit into
base: afn-neutral-limiters
Choose a base branch
from

Conversation

bendudson
Copy link

Reads a mask from the mesh file. Cells that are marked are merged with their neighbours. Takes into account cell volume in the averaging.

  • If option "merge_cells" is true, read a field merge_mask from the mesh file
  • Cells with merge_mask > 1e-5 are stored in a region
  • The time derivatives of N, P and NV in these marked cells are merged with their neighbours in the Y (poloidal) direction: The cell is split in two, each side is averaged with its neighbour, and then the marked cell is the average.
    This takes account of the volume of the cell, so e.g. particle content should be preserved.

Reads a mask from the mesh file. Cells that are marked are merged
with their neighbours. Takes into account cell volume in the averaging.
@mikekryjak
Copy link
Owner

@bendudson thanks for this. There is one snag - I think you wrote this branch off afn-neutral-limiters, i.e. the new redoing of the limiters, but I have parked this because we need a better preconditioner to continue. I have switched back to the old limiters implementation in #6.

Because of this, it would probably be more useful to base this PR on master. I haven't done much rebasing before, so for now I just made a new branch (https://github.com/bendudson/hermes-3/tree/merge-cells-master) and cherry picked this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants